Condense packaged JSON resources during the build phase via profile #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #2860 I added the condense-json action to the build section of each project where we want it. The problem with that is it requires everyone to have a built copy of the fhir-tools project in order for our fhir-parent build to be successful. This PR updates the approach by introducing a build profile in fhir-parent (and fhir-examples) for controlling whether to strip the formatting of **all** JSON resources across all modules. Additionally, this PR adds this new profile to a select few of the CI actions *and* our release action (so that the release jars will benefit from the savings). Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre
force-pushed
the
condense-json
branch
from
9539e60 to
9c0e973
Compare
lmsurpre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2860 I added the condense-json action to the build section
of each project where we want it.
The problem with that is it requires everyone to have a built copy of the fhir-tools project
in order for our fhir-parent build to be successful.
This PR updates the approach by introducing a build profile in fhir-parent (and fhir-examples)
for controlling whether to strip the formatting of all JSON resources across all modules.
This should be safe to do and prevents us from needing to declare the profile in each individual module.
Additionally, this PR adds this new profile to a select few of the CI actions and our release action
(so that the release jars will benefit from the savings).
Note: c4bb.openapi.json and plan-net.openapi.json were removed because these files were unused
and they could not be parsed with our JSON parser (parsson). See eclipse-ee4j/parsson#43
for more info.
Signed-off-by: Lee Surprenant [email protected]