Condense packaged JSON resources during the build phase #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prb112
approved these changes
Oct 15, 2021
lmsurpre
force-pushed
the
c4bb-ig-patch
branch
4 times, most recently
from
7c455e1 to
a274aa7
Compare
prb112
reviewed
Oct 15, 2021
fhir-tools/src/main/java/com/ibm/fhir/ig/plugin/CondenseAndCopyFileVisitor.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Oct 15, 2021
| <artifactId>jakarta.json</artifactId> | ||
| <version>2.0.1</version> | ||
| <version>1.0.0</version> | ||
| </dependency> |
There was a problem hiding this comment.
what about javadocs? no automation update done for that?
In the past, we kept these resources in their condensed / non-pretty format, but that made it hard to review changes and so we recently converted them to their pretty-printed flavor instead. The problem there is that the extra whitespace leads to a noticable size difference for the jars. On my system, removing this excess whitespace during the build reduces the size between 10 and 18%: carin-bb: 933,281 to 766,640 us-core: 1,443,884 to 1,212,573 fhir-registry: 19,585,400 to 17,758,332 Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre
force-pushed
the
c4bb-ig-patch
branch
from
a274aa7 to
43afd76
Compare
we don't actually publish the javadoc for fhir-tools, but we still need to build it (at least until its usage is hidden behind a profile) Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre
added a commit
that referenced
this pull request
Oct 18, 2021
In #2860 I added the condense-json action to the build section of each project where we want it. The problem with that is it requires everyone to have a built copy of the fhir-tools project in order for our fhir-parent build to be successful. This PR updates the approach by introducing a build profile in fhir-parent (and fhir-examples) for controlling whether to strip the formatting of **all** JSON resources across all modules. Additionally, this PR adds this new profile to a select few of the CI actions *and* our release action (so that the release jars will benefit from the savings). Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre
added a commit
that referenced
this pull request
Oct 18, 2021
In #2860 I added the condense-json action to the build section of each project where we want it. The problem with that is it requires everyone to have a built copy of the fhir-tools project in order for our fhir-parent build to be successful. This PR updates the approach by introducing a build profile in fhir-parent (and fhir-examples) for controlling whether to strip the formatting of **all** JSON resources across all modules. Additionally, this PR adds this new profile to a select few of the CI actions *and* our release action (so that the release jars will benefit from the savings). Signed-off-by: Lee Surprenant <[email protected]>
|
I'm closing this in favor of #2864. By moving the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we kept these resources in their condensed / non-pretty
format, but that made it hard to review changes and so we recently
converted them to their pretty-printed flavor instead.
The problem there is that the extra whitespace leads to a noticable size
difference for the jars.
On my system, removing this excess whitespace during the build
reduces the size between 16% and 18% for the IGs and almost 10% for the
fhir-registry that contains the base resources.
carin-bb: 933,281 to 766,640
us-core: 1,443,884 to 1,212,573
fhir-registry: 19,585,400 to 17,758,332
Signed-off-by: Lee Surprenant [email protected]