Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for odor mixtures #263

Open
bruno-f-cruz opened this issue Jun 30, 2024 · 0 comments
Open

Add support for odor mixtures #263

bruno-f-cruz opened this issue Jun 30, 2024 · 0 comments
Assignees
Labels
bonsai enhancement New feature or request
Milestone

Comments

@bruno-f-cruz
Copy link
Collaborator

Each patch can only use a single odor. This can easily change and should be afforded by the schema here:

class OdorSpecification(BaseModel):
    index: int = Field(..., ge=0, le=3, description="Index of the odor to be used")
    concentration: float = Field(default=1, ge=0, le=1, description="Concentration of the odor")

one idea would be to do away with the "index" property and simply turn "concentration" into an array where each position of the array sets the concentration of a specific channel.

class OdorSpecification(BaseModel):
    concentration: List[float]
@bruno-f-cruz bruno-f-cruz added this to the Next milestone milestone Jun 30, 2024
@bruno-f-cruz bruno-f-cruz self-assigned this Jun 30, 2024
bruno-f-cruz added a commit that referenced this issue Jul 1, 2024
Related to Add support for odor mixtures #263
@bruno-f-cruz bruno-f-cruz added the enhancement New feature or request label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bonsai enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant