Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nullable odor index #270

Open
bruno-f-cruz opened this issue Jul 10, 2024 · 2 comments
Open

Allow nullable odor index #270

bruno-f-cruz opened this issue Jul 10, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bruno-f-cruz
Copy link
Collaborator

bruno-f-cruz commented Jul 10, 2024

This would allow an experiment to be specified in such a way that it would still toggle the end valves (important to ensure that the sound is reproduced) but would not require a dummy value in the index to be encoded.

class OdorSpecification(BaseModel):
index: int = Field(..., ge=0, le=3, description="Index of the odor to be used")
concentration: float = Field(default=1, ge=0, le=1, description="Concentration of the odor")

@bruno-f-cruz bruno-f-cruz added the enhancement New feature or request label Jul 10, 2024
@bruno-f-cruz bruno-f-cruz added this to the Next milestone milestone Jul 10, 2024
@bruno-f-cruz bruno-f-cruz self-assigned this Jul 10, 2024
@bruno-f-cruz
Copy link
Collaborator Author

The idea would be to simply set all odors to 0 concentration

@bruno-f-cruz
Copy link
Collaborator Author

This should be tackled at the same time as #263. I will defer this one until an experiment requires mixtures of odors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant