Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gray online encoding string again #128

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Change gray online encoding string again #128

merged 3 commits into from
Nov 20, 2024

Conversation

galenlynch
Copy link
Contributor

Second attempt!

bruno-f-cruz
bruno-f-cruz approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@bruno-f-cruz bruno-f-cruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a few formatting touches and updated the pydantic defaults too. Good to go and I will fold it into the next release.

@bruno-f-cruz bruno-f-cruz merged commit 60638c2 into main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-f-cruz bruno-f-cruz bruno-f-cruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galenlynch @bruno-f-cruz