Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BROWSER_ALWAYS_START_WEBSERVER env var #156

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Oct 19, 2024

This is a fix for the problem/hack described here: https://symfonycasts.com/screencast/last-stack/testing#loading-a-test-dev-server

When Panther goes to start a webserver, if one is already running for the project in the Symfony CLI, it does not start. When this env var is set to 1, this forces Panther to start a new webserver anyway.

Further, it is likely you want your Panther webserver running the same environment as your test suite. When this env var is set to 1, we set PANTHER_APP_ENV = APP_ENV (likely test).

@kbond kbond force-pushed the always-start-webserver branch from b549378 to 8d06fef Compare October 19, 2024 16:31
@kbond kbond merged commit 6175462 into zenstruck:1.x Oct 20, 2024
20 checks passed
@kbond kbond deleted the always-start-webserver branch October 20, 2024 23:02
kbond added a commit that referenced this pull request Nov 5, 2024
* 1.x:
  minor: unpack Foundry 2 proxies (#160)
  feat: add `BROWSER_ALWAYS_START_WEBSERVER` env var (#156)
  feat: deprecate foundry integration
  minor: fix tests
kbond added a commit that referenced this pull request Nov 5, 2024
* 1.x:
  minor: unpack Foundry 2 proxies (#160)
  feat: add `BROWSER_ALWAYS_START_WEBSERVER` env var (#156)
  feat: deprecate foundry integration
  minor: fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant