Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenOffice sources for Armenian dictionaries #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hubgit
Copy link
Contributor

@hubgit hubgit commented Sep 6, 2024

As the old Arak-29 site no longer exists, and the new site doesn't contain any spell checkers, fetch the Armenian dictionaries from the OpenOffice extensions instead, which contain the same data.

@wooorm
Copy link
Owner

wooorm commented Sep 9, 2024

Why would it be better to get unmaintained libraries through one more source?

Did you see https://github.com/wooorm/dictionaries/blob/f3bba386c50ba91805eccda869af5d915808d9ce/script/crawl.sh#L164C9-L167 btw?

@hubgit
Copy link
Contributor Author

hubgit commented Sep 9, 2024

I guess it depends whether it should always be possible to build all the dictionaries from source, or if you're happy for this repo to contain some dictionaries that aren't available anywhere else (which would be fine).

One advantage of using the new source would be that it's easier to check for and pick up updates, if it's updated from another source in the future.

I don't mind either way, happy to close this if you'd prefer to.

@hubgit
Copy link
Contributor Author

hubgit commented Sep 9, 2024

Did you see https://github.com/wooorm/dictionaries/blob/f3bba386c50ba91805eccda869af5d915808d9ce/script/crawl.sh#L164C9-L167 btw?

I did see the comment, but I suspect I may not have fully understood it 🙂

I took it to be an explanation of why the current dictionaries were chosen, but it sounds like it might actually all be part of the TODO for future improvements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants