BREAKING CHANGE: drop simple-get #443
Conversation
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
this was abandoned, as native fetch doesn't have an agent parameter unlike node-fetch |
ThaUnknown
force-pushed
the
drop-simple-get
branch
from
65398d7 to
d3b9487
Compare
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
ThaUnknown
force-pushed
the
drop-simple-get
branch
from
d3b9487 to
227ddb2
Compare
…cker into drop-simple-get
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected] |
|
this now works, but imports undici, for the socks agent, which I have mixed feelings on, maybe instead the socks agent should be provided by the users, same as http and https agent? |
# [11.0.0](v10.0.12...v11.0.0) (2023-10-31) ### Features * **major:** drop simple-get ([#443](#443)) ([bce64e1](bce64e1)) ### BREAKING CHANGES * **major:** drop simple-get * perf: drop simple-get * feat: undici agent and socks * fix: undici as dev dependency * feat: require user passed proxy objects for http and ws * chore: include undici for tests
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
replaced simple-get with fetch ponyfill, which polyfills fetch only on node
Which issue (if any) does this pull request address?
webtorrent/webtorrent#2445
Is there anything you'd like reviewers to focus on?
imports undici, for the socks agent, which I have mixed feelings on, maybe instead the socks agent should be provided by the users, same as http and https agent?