Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host aliases to deployment #120

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Add host aliases to deployment #120

merged 1 commit into from
Dec 18, 2020

Conversation

vaslabs
Copy link
Owner

@vaslabs vaslabs commented Jul 23, 2020

for #50

Some imports might be broken, may worth a scala migrations thing

@vaslabs
Copy link
Owner Author

vaslabs commented Jul 23, 2020

Also in the current state it needs documentation as the InetAddress will resolve non-ips which is either a good feature or accidental complexity

@vaslabs vaslabs changed the title Initial refactoring and impl Add host aliases to deployment Jul 23, 2020
@vaslabs vaslabs added the question Further information is requested label Jul 23, 2020
@vaslabs
Copy link
Owner Author

vaslabs commented Jul 23, 2020

I'd rather not merge this until someone requests it:

  1. I can't think of a solid use-case to actually need this, it's a workaround/hack for fixing network issues
  2. It's not documented as part of the deployment but as part of the pod schema and it could be removed(?)

@vaslabs vaslabs merged commit 02a9c83 into master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant