Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-testing.yml #13421

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update ci-testing.yml #13421

merged 1 commit into from
Nov 19, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 19, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved notification setup for GitHub Actions workflow in YOLOv5.

πŸ“Š Key Changes

  • Modified Slack notification setup in the CI workflow configuration.
  • Changed webhook format to use incoming-webhook for sending alerts.
  • Updated the payload section to utilize the webhook directly for error notifications.

🎯 Purpose & Impact

  • Enhanced Notifications: The changes ensure better communication regarding CI job failures by simplifying and securing the Slack notification process.
  • Improved Workflow Monitoring: Users and contributors can quickly receive updates and address issues, enhancing the efficiency of workflow management. πŸš€

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Nov 19, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting a πŸš€ PR to the ultralytics/yolov5 repository! To help us integrate your contribution smoothly, please ensure you review and follow the guidelines below:

  • βœ… Define a Purpose: Ensure your PR description clearly explains its purpose, linking to any relevant issues if applicable. Commit messages should be clear and concise, adhering to our project's conventions.
  • βœ… Synchronize with Source: Make sure your PR is synchronized with the main branch of ultralytics/yolov5 by clicking the 'Update branch' button, or through git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify that all Continuous Integration (CI) checks are passing. Address any issues if CI checks are failing to ensure seamless integration.
  • βœ… Update Documentation: Update and reference the appropriate documentation for any new or modified features introduced in your PR.
  • βœ… Add Tests: When applicable, include or update tests to cover your changes, ensuring that all existing and new tests are passing.
  • βœ… Sign the CLA: Please confirm that you have signed our Contributor License Agreement if this is your first contribution by writing "I have read the CLA Document and I sign the CLA" in a comment.
  • βœ… Minimize Changes: Focus your changes on the minimum needed for your enhancement or bug fix. Remember, "It is not daily increase but daily decrease, hack away the unessential." β€” Bruce Lee

Feel free to refer to our Contributing Guide for more details. This is an automated response, but an Ultralytics engineer will review your PR soon. Thank you for contributing to Ultralytics! πŸŽ‰

@glenn-jocher glenn-jocher merged commit b968b2d into master Nov 19, 2024
7 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants