Move WASM building to onLoad (fixes flaky desktop test in CI) #8127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
force-pushed
the
flaky-wasm-fix
branch
2 times, most recently
from
5ac754a to
46b7e52
Compare
hrb-hub
approved these changes
Dec 12, 2024
charlag
approved these changes
Dec 12, 2024
wrdhub
force-pushed
the
dev-mail
branch
2 times, most recently
from
37de6b1 to
9848287
Compare
We don't want to use onResolve because we can resolve the same WASM multiple times (i.e. multiple files importing the same WASM), leading to the WASM being built multiple times, possibly in parallel (which may lead to build failure).
paw-hub
force-pushed
the
flaky-wasm-fix
branch
from
46b7e52 to
356942d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to use onResolve because we can resolve the same WASM multiple times (i.e. multiple files importing the same WASM), leading to the WASM being built multiple times, possibly in parallel (which may lead to build failure).