Only allow one window to run export per user #8123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export will continue in a different window if one was closed Close #8063 Co-authored-by: wrd <[email protected]>
charlag
reviewed
Dec 12, 2024
| @@ -187,6 +199,7 @@ export class MailExportController { | |||
| } catch (e) { | |||
| if (isOfflineError(e)) { | |||
| console.log(TAG, "Offline, will retry later") | |||
| // FIXME: should we use scheduler here too? | |||
There was a problem hiding this comment.
there isn't a strong reason to, maybe only to make it testable
| @@ -73,6 +73,7 @@ export class ApplicationWindow { | |||
| private readonly localShortcut: LocalShortcutManager, | |||
| private readonly themeFacade: DesktopThemeFacade, | |||
| private readonly remoteBridge: RemoteBridge, | |||
| private desktopExportLocks: Set<string>, | |||
There was a problem hiding this comment.
napkin pitch: what if we make the "window cleanup" mechanism more generic and inject some listener here instead? and coordination of these listeners can be outside of the poor ApplicationWindow.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export will continue in a different window if one was closed
Close #8063