Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive: implement #[valuable] attributes #75

Merged
merged 14 commits into from
Aug 26, 2024
Merged

derive: implement #[valuable] attributes #75

merged 14 commits into from
Aug 26, 2024

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Nov 23, 2021

The first step for #51.

  • #[valuable(rename = "...")]
  • #[valuable(transparent)]
  • #[valuable(skip)]

(This commit was created about 5 months ago. However, I didn't open the PR at the time because something was missing, but I don't remember what it is anymore, so I'll open the PR as a draft anyway.)

@rwestphal
Copy link

Would love to see this getting added!

@taiki-e taiki-e marked this pull request as ready for review November 27, 2022 18:42
@fosskers
Copy link

fosskers commented Jul 3, 2024

Any news on this?

@taiki-e taiki-e requested review from hawkw and davidbarsky July 15, 2024 15:42
@johnhurt
Copy link

Hey, I'm not sure why this pr stalled out, but I really like the functionality and the way you've written it. I am going to try to push it forward. I added a new pr that duplicates the work you did here (and rightly attributes authorship to you). My pr also includes a macro attribute for formatting a field for including a simplified version of a field when the field's type doesn't implement Valuable. Thanks for your work here! I hope we can get it included in the actual codebase.

@taiki-e taiki-e requested a review from carllerche August 23, 2024 16:03
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, feel free to merge.

@taiki-e taiki-e merged commit 54ceb4b into master Aug 26, 2024
8 checks passed
@taiki-e taiki-e deleted the taiki-e/derive branch August 26, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants