Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Help.styleItemDescription into option/subcommand/argument #2283

Merged

Conversation

shadowspawn
Copy link
Collaborator

Problem

I noticed the inconsistency when documenting the routines in #2282.

Have option+subcommand+argument flavours for stringify but not for style. If someone wanted the description colours to match the term colours they would be out of luck. I don't think many people will want separate styles, but easy to make the separation right from the start.

stringify(object) style(string) default style
4 argumentTerm styleArgumentTerm styleArgumentText
5 argumentDescription styleItemDescription styleDescriptionText
6 optionTerm styleOptionTerm styleOptionText
7 optionDescription styleItemDescription styleDescriptionText
8 subcommandTerm styleSubcommandTerm b, c, d
9 subcommandDescription styleItemDescription styleDescriptionText

Solution

Split style for item descriptions into fine-grained option+subcommand+argument. Consistent pattern.

@shadowspawn shadowspawn merged commit 437e4e3 into tj:release/13.x Nov 26, 2024
9 checks passed
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Nov 26, 2024
@shadowspawn shadowspawn deleted the feature/split-style-item-description branch November 26, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release Merged into a branch for a future release, but not released yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants