Throw for unsupported option setup #2270
Merged
+62
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
semver: major
abetomo
approved these changes
Oct 29, 2024
shadowspawn
added
the
pending release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
People who try and use unsupported Option flags do not get an error, and have to discover themselves that there are problems at runtime.
Placeholder issue: #2235
See: #430 #479 #908 #1718 #1862 #2211 #2222 #2227
Solution
Throw for unsupported Option flags, especially for known issues — too many flags, and short flag with more than one character.
This will break some existing programs that had undetected problems. (It broke one of our tests!)
ChangeLog