Update kimageformats, libheif, libjxl #28758
Merged
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-fedin
reviewed
Dec 14, 2024
| @@ -276,7 +276,6 @@ parts: | |||
| - -DJPEGXL_ENABLE_SKCMS=OFF | |||
| override-pull: | | |||
| craftctl default | |||
| git apply $CRAFT_STAGE/patches/libjxl.patch | |||
There was a problem hiding this comment.
Entire override-pull section has no sense after that
There was a problem hiding this comment.
So you are suggesting that override-pull: can be removed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kimageformats - contains tiny fix for animated JXL images
libheif - newer version supports images from latest iPhones. Note: 1.18.2 is not newest today, but I consider it better choice now than v1.19.5, which has lot of new features and maybe needs more time to test.
libjxl - update with relatively important fixes/improvements (CVE-2024-11498, avoiding abort in release build).