reflect state of started pipeline/task when using --showlog

[avinal]

Signed-off-by: Avinal Kumar [email protected]

Changes

• this change fixes an issue where using --showlog with tkn start pipeline/task does not return a non-zero value when created taskrun/pipelinerun fails.
• fixes Return value of tkn pipeline start with --showlog does not depend on state of started pipeline #1820

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

using --showlog flag with tkn pipeline/task start now returns correct value based on final state of started pipelinerun/taskrun

[tekton-robot]

Hi @avinal. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vinamra28]

/ok-to-test

[avinal]

Will fix the test cases tomorrow.

[vinamra28]

@avinal still working on this or can we close this for now and probably you can create a fresh PR once you get time to work on this?

[avinal]

Hi @vinamra28 yes, I am working, I need help with detecting if a PR/TR has failed. I referred to the documents, https://github.com/tektoncd/pipeline/blob/main/docs/pipelineruns.md#pipelinerun-status, is status Failed, a definitive way of knowing if our PR/TR has failed? I tried a couple of other tricks, but it gives ambiguous results.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[anetbnd]

/remove-lifecycle stale Please don't stop working on that topic. It is very important how otherwise it would be possible to trigger a pipeline from another pipeline and pass the result back the first one?

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[anetbnd]

/remove-lifecycle rotten Please don't forget this PR. It is an absolutely mandatory feature to trigger tkn pipelines from another pipeline (for example github actions).

[piyush-garg]

/remove-lifecycle rotten

[tekton-robot]

@avinal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-cli-integration-tests	e30943e	link	true	/test pull-tekton-cli-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[avinal]

Will open a new PR