Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pr-template): add linter, formatter and spellchecker #410

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

anton-trunov
Copy link
Member

Closes #409

  • [ ] I have updated CHANGELOG.md
  • [ ] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.4.0 milestone Jun 12, 2024
@anton-trunov anton-trunov self-assigned this Jun 12, 2024
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the whoopsie here too? json-schemasschemas in CHANGELOG

@anton-trunov anton-trunov mentioned this pull request Jun 12, 2024
21 tasks
@anton-trunov anton-trunov merged commit 2afe425 into main Jun 12, 2024
3 checks passed
@anton-trunov anton-trunov deleted the update-pr-template branch June 12, 2024 12:10
@anton-trunov
Copy link
Member Author

json-schemas → schemas in CHANGELOG

@novusnota added it to #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PR template with a point about linter, formatter and spellchecker
2 participants