Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tip about using make:messenger-middleware #20337

Open
wants to merge 2 commits into
base: 7.1
Choose a base branch
from

Conversation

alsciende
Copy link
Contributor

Add a tip about using make:messenger-middleware to create custom Middlewares, because it's easy to skip the importance of the "$stack->next()->handle($envelope, $stack)" line. Might save someone's time.

Add a tip about using make:messenger-middleware to create custom Middlewares, because it's easy to skip the importance of the "$stack->next()->handle($envelope, $stack)" line. Might save someone's time.
Remove link to Maker bundle
@@ -2836,6 +2836,11 @@ and a different instance will be created per bus.
$bus->middleware()->id('App\Middleware\AnotherMiddleware');
};

.. tip::

If you have installed the Maker bundle, you can use the ``make:messenger-middleware`` command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have installed the Maker bundle, you can use the ``make:messenger-middleware`` command
If you have installed the MakerBundle, you can use the ``make:messenger-middleware`` command

Cosmetic but I have the impression to see it written this way most of the time in documentation
And we may can add link to bundle documentation too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find a way to link to the bundle documentation (see first commit). So I checked some other pages and often there was no link to the bundles pages.

@OskarStark OskarStark changed the title Add a tip about using make:messenger-middleware Add a tip about using make:messenger-middleware Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants