-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish source api #415
base: master
Are you sure you want to change the base?
Publish source api #415
Conversation
7abfce6
to
4962d7e
Compare
This API would be useful for me, so I brought this branch up-to-date in #444. |
Merge master and add a test for `register_template_source`
pub fn get_templates(&self) -> &HashMap<String, Template> { | ||
&self.templates | ||
/// Return all registered template names | ||
pub fn get_template_names(&self) -> Vec<String> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad that we didn't catch the 4.0 release train to ship this break change.
With the Source
API, the original get_templates() -> &HashMap<String, Template>
has lost its meaning
@mkantor may I know your use case for this feature? |
My use case is to set up a registry from already-open With handlebars-rust 3.x I'm using the old If this doesn't get merged I'll probably use the path with |
I ended up using |
No description provided.