Handle inconsistent OpenACC loop clauses #2763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
added
the
NG-ARCH
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2763 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 354 354
Lines 48990 49000 +10
=======================================
+ Hits 48926 48936 +10
Misses 64 64 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2717.
In PSyACC, we disallow sequential clauses to be used in conjuction with gang and/or vector clauses because the combination doesn't make sense. This PR handles such clause combinations in a similar way.
I also noticed that the private
ACCLoopDirective._gang(etc.) members are often accessed rather than the public propertiesACCLoopDirective.gang, so addressed this. The newACCLoopDirective._check_clauses_consistentmethod is used in a few places that seem sensible.