Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(towards #2671) Parallel array privatisation #2697

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

sergisiso
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (652ad61) to head (0d03431).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2697   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         354      354           
  Lines       49046    49108   +62     
=======================================
+ Hits        48982    49044   +62     
  Misses         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergisiso
Copy link
Collaborator Author

sergisiso commented Sep 5, 2024

@arporter It turns out that the compare_output.py that I added in my previous PR fails to properly compare the run.stat because the scientific notation with "D" is not converted to floats by python, which expects an "E". This is not a problem for passthrough, but the OpenMP workflows return different results (I was surprised that we didn't need to exclude any file as ecmwf needed some for reproducibility!). I will fix it in this PR as the OpenMP results are the main focus for this one.

@sergisiso
Copy link
Collaborator Author

Unfortunately the new excluded files for NEMOv5 GPU cause a performance degradation in NEMOv4, so I will wait a bit for #2725 and #2685 as these remove some of the exclusions.

Additionally I can filter by routine name instead of file, as now all of them complete the passthrough.

@sergisiso sergisiso self-assigned this Oct 23, 2024
@sergisiso sergisiso added the Blocked An issue/PR that is blocked by one or more issues/PRs. label Oct 23, 2024
@sergisiso sergisiso mentioned this pull request Oct 24, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked An issue/PR that is blocked by one or more issues/PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant