Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otter profiling code for #1774 #2535

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

LonelyCat124
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (12addeb) to head (94beae1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2535   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         356      356           
  Lines       47861    47942   +81     
=======================================
+ Hits        47793    47874   +81     
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LonelyCat124
Copy link
Collaborator Author

Waiting on #2537 and #2538 to continue this.

@LonelyCat124
Copy link
Collaborator Author

LonelyCat124 commented Apr 12, 2024

Preprocessor support added so code generation can now work correctly.

I want to force some names to remain fixed, and I want to have a unit test for the OmpSerialRegion as well.

Edit: That test is added, just force fixed names remains when that PR is done.

@LonelyCat124 LonelyCat124 marked this pull request as ready for review April 16, 2024 14:49
@LonelyCat124
Copy link
Collaborator Author

@arporter I think this is ready for a first look - there are some statement orderings that are slightly different to what I did by hand (when the code adds taskwaits in itself) but they don't change the functionality so I have no issue leaving them as is.

@LonelyCat124
Copy link
Collaborator Author

We don't need this in a release for the end of the tasking project - so there's no reason to rush completion of this PR. I think the logic is all here for this and we can decide how we want to fit this into PSyclone (perhaps as Joerg suggests in the examples, though I think we still end up with some extensions of the transformation to be able to do this correctly inside the example script)

@arporter
Copy link
Member

arporter commented Apr 29, 2024

We don't need this in a release for the end of the tasking project - so there's no reason to rush completion of this PR. I think the logic is all here for this and we can decide how we want to fit this into PSyclone (perhaps as Joerg suggests in the examples, though I think we still end up with some extensions of the transformation to be able to do this correctly inside the example script)

Great. I think we go for an example then. @hiker, feel free to add your comments about this on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants