-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otter profiling code for #1774 #2535
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2535 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 356 356
Lines 47861 47942 +81
=======================================
+ Hits 47793 47874 +81
Misses 68 68 ☔ View full report in Codecov by Sentry. |
…ed to add another test for multiple taskwaits
Preprocessor support added so code generation can now work correctly. I want to force some names to remain fixed, and I want to have a unit test for the OmpSerialRegion as well. Edit: That test is added, just force fixed names remains when that PR is done. |
@arporter I think this is ready for a first look - there are some statement orderings that are slightly different to what I did by hand (when the code adds taskwaits in itself) but they don't change the functionality so I have no issue leaving them as is. |
We don't need this in a release for the end of the tasking project - so there's no reason to rush completion of this PR. I think the logic is all here for this and we can decide how we want to fit this into PSyclone (perhaps as Joerg suggests in the examples, though I think we still end up with some extensions of the transformation to be able to do this correctly inside the example script) |
Great. I think we go for an example then. @hiker, feel free to add your comments about this on here. |
No description provided.