Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packages from "symfony/*" ^7 #2430

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

phansys
Copy link
Member

@phansys phansys commented Dec 14, 2023

Subject

I am targeting this branch, because these changes respect BC.

Supersedes #2425.

Changelog

### Added
- Support for packages from `symfony/*` 7.x

To do

  • Use a stable constraint for sonata-project/classification-bundle.

*/
final class GenerateThumbnailsHandler implements MessageHandlerInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a BC break for non SF 7 users.

We should use something like
https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/ArgumentResolver/CompatibleValueResolverInterface.php

if (interface_exists(MessageHandlerInterface::class)) {
    /** @internal */
    interface CompatibleMessageHandlerInterface extends MessageHandlerInterface
    {
    }
} else {
    /** @internal */
    interface CompatibleMessageHandlerInterface
    {
    }
}

and use it here:

final class GenerateThumbnailsHandler implements CompatibleMessageHandlerInterface

src/Admin/BaseMediaAdmin.php Show resolved Hide resolved
src/Admin/BaseMediaAdmin.php Show resolved Hide resolved
src/Admin/GalleryAdmin.php Show resolved Hide resolved
src/Controller/MediaAdminController.php Show resolved Hide resolved
src/Controller/MediaAdminController.php Show resolved Hide resolved
VincentLanglet
VincentLanglet previously approved these changes Dec 14, 2023
@phansys phansys marked this pull request as ready for review December 14, 2023 14:40
@phansys phansys requested a review from a team December 14, 2023 15:11
@VincentLanglet VincentLanglet merged commit 060701e into sonata-project:4.x Dec 14, 2023
25 checks passed
@phansys phansys deleted the symfony_7 branch December 14, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants