-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow packages from "symfony/*" ^7 #2430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
requested changes
Dec 14, 2023
*/ | ||
final class GenerateThumbnailsHandler implements MessageHandlerInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a BC break for non SF 7 users.
We should use something like
https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/ArgumentResolver/CompatibleValueResolverInterface.php
if (interface_exists(MessageHandlerInterface::class)) {
/** @internal */
interface CompatibleMessageHandlerInterface extends MessageHandlerInterface
{
}
} else {
/** @internal */
interface CompatibleMessageHandlerInterface
{
}
}
and use it here:
final class GenerateThumbnailsHandler implements CompatibleMessageHandlerInterface
VincentLanglet
previously approved these changes
Dec 14, 2023
phansys
force-pushed
the
symfony_7
branch
2 times, most recently
from
December 14, 2023 14:06
8bd0194
to
7d17d1b
Compare
VincentLanglet
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because these changes respect BC.
Supersedes #2425.
Changelog
To do
sonata-project/classification-bundle
.