Upgrade Select2 to v4 #7048
Merged
Upgrade Select2 to v4 #7048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
commented
Apr 13, 2021
src/Resources/views/Form/Type/sonata_type_model_autocomplete.html.twig
Outdated
Show resolved
Hide resolved
jordisala1991
force-pushed
the
feature/upgrade-select2-v4
branch
from
6aaa775 to
f061c4a
Compare
core23
reviewed
Apr 13, 2021
31 tasks
jordisala1991
force-pushed
the
feature/upgrade-select2-v4
branch
3 times, most recently
from
f03abf0 to
bf3bf83
Compare
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
feature/upgrade-select2-v4
branch
from
841e617 to
b4b7178
Compare
jordisala1991
force-pushed
the
feature/upgrade-select2-v4
branch
from
b4b7178 to
b590a55
Compare
jordisala1991
commented
Apr 14, 2021
| @@ -182,12 +182,12 @@ Full Configuration Options | |||
| - bundles/sonataadmin/dist/bootstrap/bootstrap.min.css | |||
| - bundles/sonataadmin/dist/components-font-awesome/css/font-awesome.min.css | |||
| - bundles/sonataadmin/dist/ionicons/css/ionicons.min.css | |||
| - bundles/sonataadmin/dist/admin-lte/css/AdminLTE.min.css | |||
| - bundles/sonataadmin/dist/admin-lte/css/AdminLTE-without-plugins.min.css | |||
There was a problem hiding this comment.
Default admin-lte has custom styles for select2, fullcalendar and bootstrap-social.
From those, we are only using select2, and the 4 version has incompatible styles for it: ColorlibHQ/AdminLTE#668
VincentLanglet
approved these changes
Apr 14, 2021
phansys
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC break.
Part of: #7049
Changelog