Ignore exception for trying to resize a column with text255 compresssion encoding #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text255 compresssion encoding (#1370) Pre-0.27.0 Schema DDL was making the compression encoding of text255. However, text255 doesn't allow to alter the column therefore we get exception while trying to resize the column. In order to solve this problem, Schema DDL uses zstd compression encoding with enum fields as well starting with 0.27.0. However compression encoding of the existing columns won't be updated after this change and we will continue to get exception when those columns are tried to be resized. This commit is for catching and ignoring those exceptions.
Github removed sbt from the ubuntu runner image therefore we need to add sbt installation step to CI.
spenes
force-pushed
the
fix/enum-resize-problem
branch
from
dd27701 to
15eafda
Compare
istreeter
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: PDP-1621
Pre-0.27.0 Schema DDL was making the compression encoding of
text255. However,text255doesn't allow to alter the column therefore we get exception while trying to resize the column. In order to solve this problem, Schema DDL uses zstd compression encoding with enum fields as well starting with 0.27.0.However compression encoding of the existing columns won't be updated after this change and we will continue to get exception when those columns are tried to be resized. This PR is for catching and ignoring those exceptions.