Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.snowplowanalytics.snowplow.ecommerce/snowplow_ecommerce_action/jsonschema/1-0-2 #1299

Closed

Conversation

igneel64
Copy link
Contributor

@igneel64 igneel64 commented May 2, 2023

Add transaction_error as a new action to be paired with #1297

Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igneel64
Copy link
Contributor Author

igneel64 commented May 2, 2023

Will try to add into #1258

@igneel64
Copy link
Contributor Author

igneel64 commented Jun 1, 2023

@istreeter In this PR the max enum goes from 16 to 17. Does this still pose an issue with snowplow/snowplow-rdb-loader#1158 ?

@igneel64 igneel64 force-pushed the issue/1298-ecommerce_transaction_error_action branch from c076982 to dfc1c59 Compare June 1, 2023 10:15
@igneel64
Copy link
Contributor Author

igneel64 commented Jun 1, 2023

Changed to trns_error to avoid this :)

@igneel64
Copy link
Contributor Author

igneel64 commented Aug 1, 2023

Added in:
#1305

@igneel64 igneel64 closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants