Merge pull request #268 from skttl/develop

1.2.8
skttl · Nov 19, 2021 · baea08e · baea08e
2 parents 070fc9b + 3fd1b6d
commit baea08e
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.2.8
+- Fixes bug in DataValueReference for media tracking, where custom DTGEs were not recognized. 4db5cdd
+
+## 1.2.7
+- Fixes: Unable to save a component which previously failed validation #231
+- Null-check for err object when submiting #236
+
 ## 1.2.6 - 2020-12-07
 - Fix: Error saving temp blueprint
 - Fix: issue when previewing linked content items

diff --git a/appveyor.yml b/appveyor.yml
@@ -1,7 +1,7 @@
 image: Visual Studio 2017
 
 # version format
-version: 1.2.7.{build}
+version: 1.2.8.{build}
 
 # UMBRACO_PACKAGE_PRERELEASE_SUFFIX if a rtm release build this should be blank, otherwise if empty will default to alpha
 # example UMBRACO_PACKAGE_PRERELEASE_SUFFIX=beta

diff --git a/docs/developers-guide.md b/docs/developers-guide.md
@@ -10,7 +10,8 @@
 5. [Rendering a Doc Type Grid Editor](#rendering-a-doc-type-grid-editor)
     1. [Rendering Alternative Preview Content](#rendering-alternative-preview-content)
     2. [DocTypeGridEditorSurfaceController](#doctypegrideditorsurfacecontroller)
-6. [Useful Links](#useful-links)
+6. [Value Processors](#value-processors)
+7. [Useful Links](#useful-links)
 
 ---
 

diff --git a/src/Our.Umbraco.DocTypeGridEditor/ValueProcessing/DocTypeGridEditorDataValueReference.cs b/src/Our.Umbraco.DocTypeGridEditor/ValueProcessing/DocTypeGridEditorDataValueReference.cs
@@ -71,7 +71,7 @@ internal GridValue DeserializeGridValue(string rawJson, out IEnumerable<DocTypeG
             {
                 // Find all controls that uses DTGE editor
                 var controls = grid.Sections.SelectMany(x => x.Rows.SelectMany(r => r.Areas).SelectMany(a => a.Controls)).ToArray();
-                dtgeValues = controls.Where(x => x.Editor.Alias.ToLowerInvariant() == "doctype").Select(x => x.Value.ToObject<DocTypeGridEditorValue>());
+                dtgeValues = controls.Where(x => x.Value["dtgeContentTypeAlias"] != null).Select(x => x.Value.ToObject<DocTypeGridEditorValue>());
             }
             else
             {

diff --git a/...ocTypeGridEditor/Web/UI/App_Plugins/DocTypeGridEditor/Js/doctypegrideditor.controllers.js b/...ocTypeGridEditor/Web/UI/App_Plugins/DocTypeGridEditor/Js/doctypegrideditor.controllers.js
@@ -267,6 +267,7 @@ angular.module("umbraco").controller("Our.Umbraco.DocTypeGridEditor.Dialogs.DocT
 
             function submit() {
                 if ($scope.model.submit) {
+                    serverValidationManager.reset();
                     vm.saveButtonState = "busy";
                     $scope.model.node.name = "Dtge Temp: " + $scope.model.node.key;
                     $scope.model.node.variants[0].name = $scope.model.node.name