Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleCommerce with Dotnet Core 5 - Build Images as standalone or with postgres and pgadmin via dockercompose #960

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sergiohinojosa
Copy link

Hi dear maintainers,

nice shop! tbh I'm new to dot net (core). I found this ecommerce shop and I think it'll be great to showcase some usecases for an upcoming MS event/demo.
I made some adjustments that I want to share with you. The changes are basically:

  • String replacement 2018 -> 2020 (I did not try it with 2021 since it could break things having data in the future, don't want to test it)
  • simpl-build.sh and simpl-build-sqlite.sh which pair with Dockerfile and Dockerfile-sqlite for building the show either standalone or depending on postgresql.
  • howto-build-withdocker.md Some documentation on how to build the shop. Specially useful for newbys. A new guy (like me) has to figure out how to change appsettings.json match the EF Frameworks and match the connection. Maybe modifying the readme with run simpl-build-sqlite.sh or modify the simpl-build.shto verify and otherwise spin a postgresql container. Should be easy to adapt. This way the user can download the repo and build the solution very easy.
  • docker-compose.yaml I added a docker-compose.yaml file which can speed development and testing having multiple stages. In there you'll find 3 containers: simplcommerce, postgresql and pgadmin.

thanks and best
Sergio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant