SimpleCommerce with Dotnet Core 5 - Build Images as standalone or with postgres and pgadmin via dockercompose #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dear maintainers,
nice shop! tbh I'm new to dot net (core). I found this ecommerce shop and I think it'll be great to showcase some usecases for an upcoming MS event/demo.
I made some adjustments that I want to share with you. The changes are basically:
simpl-build.sh
andsimpl-build-sqlite.sh
which pair with Dockerfile and Dockerfile-sqlite for building the show either standalone or depending on postgresql.appsettings.json
match the EF Frameworks and match the connection. Maybe modifying the readme with runsimpl-build-sqlite.sh
or modify thesimpl-build.sh
to verify and otherwise spin a postgresql container. Should be easy to adapt. This way the user can download the repo and build the solution very easy.docker-compose.yaml
I added a docker-compose.yaml file which can speed development and testing having multiple stages. In there you'll find 3 containers: simplcommerce, postgresql and pgadmin.thanks and best
Sergio