-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infrastrucutre test cases #1074
base: master
Are you sure you want to change the base?
infrastrucutre test cases #1074
Conversation
cannot merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format and remove unnecessary comments
@@ -1,6 +1,7 @@ | |||
{ | |||
"ConnectionStrings": { | |||
"DefaultConnection": "Server=.;Database=SimplCommerce;Trusted_Connection=True;TrustServerCertificate=true;MultipleActiveResultSets=true" | |||
"DefaultConnection": "server=DotNetFSD\\SQLEXPRESS; database=SimplCommerce; user id=sa; password=pass@123;trustservercertificate=true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change
@@ -0,0 +1 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty?!!
using SimplCommerce.Infrastructure.Helpers; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using SimplCommerce.Infrastructure.Helpers; | |
using SimplCommerce.Infrastructure.Helpers; | |
} | ||
|
||
[Fact] | ||
public void IsZeroDecimalCurrencies_WithUnknownCurrency_ReturnsFalse() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use Theory
for the above tests instead of Fact
Assert.False(result); | ||
} | ||
[Fact] | ||
public void IsZeroDecimalCurrencies_WithUnknown2Currency_ReturnsFalse() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Assert.False(result); | ||
|
||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra whitespace
Assert.True(createdMenu.IsPublished); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespaces!!
using SimplCommerce.Module.Core.Data; | ||
using SimplCommerce.Module.Core.Extensions; | ||
using SimplCommerce.Module.Core.Models; | ||
using Xunit; | ||
|
||
namespace SimplCommerce.Module.Core.Tests.Components | ||
/*namespace SimplCommerce.Module.Core.Tests.Components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
I have written remaining test cases for infrastructure module and some for Cms module1: