Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert supporting for forbidden permission #352

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

sigoden
Copy link
Owner

@sigoden sigoden commented Jan 17, 2024

#329 supports forbidden permission, but this pr reverts it.

why revert? becase many operations are anti-pattern and difficult to process. Take /dir1:rw,/dir1/dir2:rw as an example.

  • When deleting /dir1, should /dir1/dir2 be deleted?
  • When moving /dir1, should /dir1/dir2 be moved?
  • When zip downloading /dir1, do you need to include /dir1/dir2?
  • After renaming /dir1, the constraints of /dir1/dir2 fail. What should I do?

@sigoden sigoden merged commit 95eb648 into main Jan 17, 2024
3 checks passed
@sigoden sigoden deleted the feat-revert-forbid branch January 17, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant