-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiQC docs: add modules index page #246
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Great work, this looks much better! 👏🏻 Main downside I see in the deployment preview is that the module pages no longer show the sidebar, eg. here. This is a bit of a problem as you suddenly can't navigate elsewhere in the docs. Minor, not blocking: It'd be great to have a filter for the table like in the old page 🤔 Can look into that in the future though. |
I think this solves all the problems: MultiQC/MultiQC#2904 Adds a reasonable index (also the "development/index" page is not so uninformative), and the sidebar main items are now clickable. |
Thanks for this PR! Is it possible to turn the expand arrows in a different direction? They face inward ">" and are large while the other doc sets use small ">"s. |
We can tweak CSS for sure, but that's just the default Docusaurus style, and there is a benefit in using the default, as the website immediately looks familiar to those who have seen other Docusaurus backed docs :) |
multiqc_docs/sidebar.js
Outdated
@@ -50,8 +59,8 @@ export default { | |||
}, | |||
{ | |||
"type": "category", | |||
"label": "Supported tools", | |||
"collapsed": true, | |||
"label": "Modules", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been trying to get away from the term "Modules" as it means so many different things. With the unified search it'll also come up for nextflow modules, nf-core modules, etc etc.
Is there a reason to move away from "Supported Tools"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe you're right and we should move away entirely.
I'd at least like to leave this page as "Supported Tools" anyway. The folks looking for these pages are typically end users and not developers. I think "Supported Tools" is more user friendly and intuitive.
I think we've tweaked the style on our side already - hence the difference. I'm happy with either option but it should be consistent. |
There aren't any changes to the styling here, I guess the arrows are reverting because of the addition of @vladsavelyev why was this needed? I think I'll need to go into the theme customisation and add support for this explicitly I guess. |
And before going much further - whilst I agree this is an improvement I still don't like it as much as the old MultiQC equivalent page. I would prefer to hand-code a table view that looks like the one we had before, and remove the tool names from the side nav. We should be able to still have functionality like the filter box etc. We can write custom React components in the Docusaurus theme as needed, then build the HTML / MD in the MultiQC repo accordingly. I can take a look at this if needed, though might be post-summit now. |
Use a modules index page built here MultiQC/MultiQC#2903 instead of a sidebar section.