Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: to/from PyTorch Tensor #3259

Conversation

maxymnaumchyk
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 33.96226% with 35 lines in your changes missing coverage. Please review.

Project coverage is 81.94%. Comparing base (b749e49) to head (199468d).
Report is 167 commits behind head on main.

Files with missing lines Patch % Lines
src/awkward/operations/ak_to_torch.py 33.33% 18 Missing ⚠️
src/awkward/operations/ak_from_torch.py 29.16% 17 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/operations/__init__.py 100.00% <100.00%> (ø)
src/awkward/operations/ak_from_torch.py 29.16% <29.16%> (ø)
src/awkward/operations/ak_to_torch.py 33.33% <33.33%> (ø)

... and 105 files with indirect coverage changes

@maxymnaumchyk maxymnaumchyk marked this pull request as ready for review September 27, 2024 12:32
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a few suggestions.

src/awkward/operations/ak_from_torch.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_to_torch.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_to_torch.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_to_torch.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_to_torch.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_to_torch.py Show resolved Hide resolved
src/awkward/operations/ak_to_torch.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@maxymnaumchyk maxymnaumchyk merged commit ee5865a into scikit-hep:main Oct 3, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants