Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the max and min periodicity tolerances to fix flaky tests #1937

Conversation

saikishor
Copy link
Member

I've increased the tolerances of Min and Max periodicity of the tests as this completely depends on the load of the CPUs and this doesn't make sense to be that restrictive as the main part of the tests we are checking the Average periodicity

Fixes: #1908

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (bb087e2) to head (7c79eaf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1937   +/-   ##
=======================================
  Coverage   87.72%   87.73%           
=======================================
  Files         122      122           
  Lines       13010    13010           
  Branches     1165     1165           
=======================================
+ Hits        11413    11414    +1     
  Misses       1165     1165           
+ Partials      432      431    -1     
Flag Coverage Δ
unittests 87.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ontroller_manager/test/test_controller_manager.cpp 96.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adressing the issue. I understand that we are more interested in the average than on min/max on the github runners.

@saikishor
Copy link
Member Author

Thx for adressing the issue. I understand that we are more interested in the average than on min/max on the github runners.

Yes. You are right

@christophfroehlich christophfroehlich merged commit 7374c43 into ros-controls:master Dec 13, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestControllerManagerWithUpdateRates is flaky
2 participants