Upgrade llvm 18 zig 13 #6921
Merged
Upgrade llvm 18 zig 13 #6921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update nixpkgs to 24.05 fixup
lukewilliamboswell
force-pushed
the
upgrade-llvm-zig
branch
from
409b54c to
c47915a
Compare
This reverts commit d5dfdfb.
bhansconnect
added a commit
that referenced
this pull request
Dec 12, 2024
To get #6921 working, we need the benchmark script to pull glue.zig correctly on main. As such, we need to load it into a lib dir such that it is found in the correct relative path. This hopefully will get the benchmarking working on the other PR. Also, switch over to `lib` dir first cause that is what is seen in the wide.
bhansconnect
added a commit
that referenced
this pull request
Dec 12, 2024
To get #6921 working, we need the benchmark script to pull glue.zig correctly on main. As such, we need to load it into a lib dir such that it is found in the correct relative path. This hopefully will get the benchmarking working on the other PR. Also, switch over to `lib` dir first cause that is what is seen in the wide.
bhansconnect
added a commit
that referenced
this pull request
Dec 12, 2024
To get #6921 working, we need the benchmark script to pull glue.zig correctly on main. As such, we need to load it into a lib dir such that it is found in the correct relative path. This hopefully will get the benchmarking working on the other PR. Also, switch over to `lib` dir first cause that is what is seen in the wide.
crates/compiler/test_gen/src/helpers/wasm_linking_test_host.zig
Outdated
Show resolved
Hide resolved
Comment on lines
+37
to
+38
| // TODO: double check how much time is spent verifying here and below. | ||
| // For real compilation, we may not want to pay the cost. |
There was a problem hiding this comment.
@bhansconnect do you think we need to do this before merging?
There was a problem hiding this comment.
So I just did some quick test. Tested with a debug build of helloworld (cause that is the case where a little extra cost hurts the most).
The check here costs about 15ms. The second check is free. The total build time before linking is about 100ms. Linking without the surgical linker is about 150ms. My gut feeling is just to leave this for now with the todo and circle back later. Long term, we probably want to remove at least the first check here (when we do make it dump the llvm ir if the passes fail to run). But for now, verifying early seems like a good idea.
Anton-4
added a commit
that referenced
this pull request
Dec 13, 2024
examples/cli was removed in #6921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.