Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inference_ids to model blocks #615

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

robiscoding
Copy link
Contributor

Description

  • Returning inference_ids in model workflow blocks

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  • Tested by pointing workflow UI to locally running container and running inferences for each model type and confirming that the inference_id appeared in the results

Any specific deployment considerations

  • N/A

Docs

  • Docs updated? What were the changes:

Copy link
Collaborator

@PawelPeczek-Roboflow PawelPeczek-Roboflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm existence of that output in integration tests that we use blocks

on separate note: I believe that this change is to compensate for #567, right?

@robiscoding
Copy link
Contributor Author

robiscoding commented Aug 28, 2024

Please confirm existence of that output in integration tests that we use blocks

Will do, I was hoping to get some test failures here to narrow down where the changes needed to be made, but it's odd that none of them failed

on separate note: I believe that this change is to compensate for #567, right?

Correct

@PawelPeczek-Roboflow
Copy link
Collaborator

basically this is non-breaking change so no test fails

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit a2d06b5 into main Aug 29, 2024
58 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the add-inference-ids-detection-blocks branch August 29, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants