Fix _pnn50: Use float division and correct array len #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integer division has always yielded 0. The array length must be taken from the diff array (which is 1 less than rri)
|
Hi @riccioclista, thank you very much for your contribution. Could you please add a unit test that reproduces this error? |
rhenanbartels
force-pushed
the
develop
branch
from
77251c9 to
35cdd1b
Compare
rhenanbartels
force-pushed
the
develop
branch
from
342ba46 to
6a6d851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer division has always yielded 0.
The array length must be taken from the diff array (which is 1 less than rri)