Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider mode - Skip ACM install based on config value #11033

Merged

Conversation

jilju
Copy link
Contributor

@jilju jilju commented Dec 11, 2024

During the creation of hosted cluster, skip installation of ACM if the value of "deploy_acm_hub_cluster" is False.
This change is required for provider mode RDR setup.

@jilju jilju requested a review from a team as a code owner December 11, 2024 12:52
@jilju jilju added the provider-client Provider-client solution label Dec 11, 2024
Copy link
Contributor

@amr1ta amr1ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@jilju jilju added the Verified Mark when PR was verified and log provided label Dec 12, 2024
Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amr1ta, fbalak, jilju

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fbalak fbalak merged commit 83fd298 into red-hat-storage:master Dec 12, 2024
6 of 7 checks passed
@jilju jilju deleted the skip-acm-install-based-on-config-value branch December 13, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm provider-client Provider-client solution size/XS Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants