Deploy an external mode cluster and create resources with the rbd rados namespace #11019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yitzhak12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vavuthu
reviewed
Dec 10, 2024
ocs_ci/helpers/helpers.py
Outdated
Comment on lines
665
to
668
| from ocs_ci.ocs.resources.storage_cluster import ( | ||
| get_storageclass_names_from_storagecluster_spec, | ||
| get_storageclass_with_rbd_namespace, | ||
| ) |
There was a problem hiding this comment.
could you move to import section. incase if there is circular dependancy, please make comment for the same
| return sc | ||
|
|
||
| log.warning(f"Didn't find the storageclass with the rbd namespace {rbd_namespace}") | ||
| return None |
There was a problem hiding this comment.
by default function returns None implicitly. so we can remove this
| rbd_namespace (str): The rbd namespace to search in the storage classes | ||
|
|
||
| Returns: | ||
| dict: The storage class with the specified rbd namespace. If not found, it returns None. |
There was a problem hiding this comment.
Suggested change
| dict: The storage class with the specified rbd namespace. If not found, it returns None. | |
| str: The storage class with the specified rbd namespace. If not found, it returns None. |
yitzhak12
force-pushed
the
create-resources-with-rbd-namesapce
branch
from
fbb27c8 to
bc6df44
Compare
pull-request-size
bot
added
size/S
yitzhak12
changed the title
…ace external mode param Signed-off-by: Itzhak Kave <[email protected]>
yitzhak12
force-pushed
the
create-resources-with-rbd-namesapce
branch
from
bc6df44 to
e4e5341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue https://issues.redhat.com/browse/RHSTOR-5519