WIP: IBM Cloud ROKS RDR changes #10977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-balogh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pull-request-size
bot
added
size/L
petr-balogh
force-pushed
the
change_ibm_cloud_zone_key
branch
from
77b7b59 to
aa4ce23
Compare
petr-balogh
force-pushed
the
change_ibm_cloud_zone_key
branch
from
0f28a36 to
f16a2a4
Compare
petr-balogh
commented
Dec 9, 2024
| @@ -11,6 +11,6 @@ DEPLOYMENT: | |||
| ENV_DATA: | |||
| # TODO: replace with 4.16 once template is available | |||
| vm_template: "rhcos-416.94.202403071059-0-vmware.x86_64" | |||
| acm_hub_channel: release-2.11 | |||
There was a problem hiding this comment.
This we need to probably change somewhere else or get ACK with @keesturam or @sidhant-agrawal that we can do change this version globally for 4.16 to ACM 2.12.
petr-balogh
changed the title
petr-balogh
commented
Dec 11, 2024
| @functools.wraps(func) | ||
| def wrapper(*args, **kwargs): | ||
| for cluster_index in range(self.nclusters): | ||
| self.switch_ctx(cluster_index) |
There was a problem hiding this comment.
We will need to use context manager which is switching back to original context or store original context and once function will finish, switch back to original context.
In RDR deployment, the zone key in ENV_DATA is used for different purpose, so changing it to worker_availability_zone here. Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
run_for_all_clusters allow to run existing function on all cluster configs. It's usefull when you need to globally update some config value for all clusters. Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
And not disable NAT-T for ROKS cluster Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
petr-balogh
force-pushed
the
change_ibm_cloud_zone_key
branch
from
7e193bf to
6584043
Compare
Signed-off-by: Petr Balogh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.