chore: change Namespace enum to stirng #964
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeager-eren
force-pushed
the
chore/change-namespace-enum-to-string
branch
from
0661216 to
52953ea
Compare
nikaaru
reviewed
Dec 10, 2024
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "name": "@rango-dev/wallets-core/namespaces/common", | |||
There was a problem hiding this comment.
NIT: The package name specified in package.json (@rango-dev/wallets-core/namespaces/common) does not comply with npm naming conventions. The issue arises because the name contains multiple slashes (/), which are not permitted except for the scope delimiter.
You can check these two links:
https://docs.npmjs.com/package-name-guidelines
https://github.com/npm/validate-npm-package-name
I suggest replacing additional slashes with hyphens: @rango-dev/wallets-core-namespaces-common.
This change ensures compatibility with npm and avoids build or publish errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using a single source of truth for Namespace.
We need to use a single type for both legacy and hub implementation. To make it more general and don't needing to always keeping the namespace updated by what Rango currently support, I changed it to
string, instead of enum. To have namespace suggestion while coding, I used a trick to suggest our supported namespaces alongside the fact that it can be any string.Fixes # (issue)
How did you test this change?
It should be compiled correctly, shouldn't affect the functionality of working with wallets.
Checklist: