Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/rf 1863 migrate clover to hub #957

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Feat/rf 1863 migrate clover to hub #957

wants to merge 3 commits into from

Conversation

nikaaru
Copy link
Member

@nikaaru nikaaru commented Nov 25, 2024 •
edited
Loading

Summary

Clover has been migrated to hub and also in addition to Solana namespace, EVM namespace has been added too.
The Solana namespace has a problem with transaction signing, which we also have on production, and we will fix it in a separate PR.

I also added changeChainSubscriber to its EVM namespace.

I took this branch from the feat/rf-1970-add-chain-change-subscribe-to-evm-namespace branch in this PR.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@nikaaru nikaaru mentioned this pull request Nov 25, 2024
Closed
7 tasks
@nikaaru nikaaru force-pushed the feat/rf-1970-add-chain-change-subscribe-to-evm-namespace branch from 9117c1a to d714cf3 Compare November 25, 2024 10:46
@nikaaru nikaaru force-pushed the feat/rf-1863-migrate-clover-to-hub branch from 68e8bda to 48944a5 Compare November 26, 2024 06:33
@nikaaru nikaaru force-pushed the feat/rf-1970-add-chain-change-subscribe-to-evm-namespace branch from d714cf3 to 4e0fa67 Compare December 1, 2024 09:17
Base automatically changed from feat/rf-1970-add-chain-change-subscribe-to-evm-namespace to next December 1, 2024 10:08
@nikaaru nikaaru force-pushed the feat/rf-1863-migrate-clover-to-hub branch from 48944a5 to c1da199 Compare December 1, 2024 10:15
yeager-eren
yeager-eren approved these changes Dec 8, 2024
View reviewed changes
wallets/core/src/hub/mod.ts Outdated Show resolved Hide resolved
wallets/provider-clover/src/actions/solana.ts Show resolved Hide resolved
@nikaaru nikaaru force-pushed the feat/rf-1863-migrate-clover-to-hub branch from 2c2e854 to a5703c2 Compare December 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeager-eren yeager-eren yeager-eren approved these changes

@RanGojo RanGojo Awaiting requested review from RanGojo RanGojo is a code owner

@samobasquiat samobasquiat Awaiting requested review from samobasquiat

@mikasackermn mikasackermn Awaiting requested review from mikasackermn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikaaru @yeager-eren