Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the sorting in the confirm wallets modal #784

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

Ikari-Shinji-re
Copy link
Member

@Ikari-Shinji-re Ikari-Shinji-re commented Jul 6, 2024

Summary

In the confirm wallets modal, if the user disconnects the selected wallet, the next wallet chosen automatically might not appear in the confirm wallets modal.

Fixes # (issue)

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@RanGojo
Copy link
Member

RanGojo commented Jul 8, 2024

I was testing your PR and faced with this situation which I think is different with what we have discussed.

Screenshot from 2024-07-08 11-24-55
Screenshot from 2024-07-08 11-25-06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants