Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cosmos snap for metamask #436

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

mikasackermn
Copy link
Collaborator

@mikasackermn mikasackermn commented Nov 13, 2023

Summary

The Cosmos snap allows developers to deploy Cosmos accounts, make transactions on Cosmos, and interact with Cosmos smart contracts. We have to implement it in the providers.

How did you test this change?

You can test this by adding the cosmos snap provider to all providers and running the widget and connecting to the Cosmos Snap and swapping in the Cosmos Blockchain. (There is a problem with the signer)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas

@mikasackermn mikasackermn force-pushed the feat/rf-937-support-cosmos-snap branch from 962b0a9 to c120190 Compare November 15, 2023 06:51
@RanGojo RanGojo self-requested a review November 15, 2023 06:58
@RanGojo RanGojo self-assigned this Nov 15, 2023
@RanGojo
Copy link
Member

RanGojo commented Nov 19, 2023

I've opened an issue on cosmos-snap repo regarding sending proto txs.
cosmos/snap#26

@mikasackermn mikasackermn force-pushed the feat/rf-937-support-cosmos-snap branch from 255a4ef to fa454c8 Compare November 29, 2023 06:26
@mikasackermn mikasackermn marked this pull request as ready for review November 29, 2023 06:46
@mikasackermn mikasackermn changed the title !WIP feat: support Cosmos Snap for Metamask feat: support Cosmos Snap for Metamask Nov 29, 2023
@RanGojo RanGojo added the wait label Dec 24, 2023
@schnetzlerjoe
Copy link

We will look into this immediately for you guys. I will reach out on channels.

@RanGojo RanGojo changed the title feat: support Cosmos Snap for Metamask feat: support cosmos snap for metamask Feb 19, 2024
@mikasackermn mikasackermn requested a review from yeager-eren as a code owner May 14, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants