-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework lesson on list, tuple, range; add enumerate & zip #639
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I really like the new parts, especially the ones with zip and enumerate. I left a few comments and suggestions, mostly fixing typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes jen kvůli dvěma chybkám. Jinak poznámky pouze informativní. Jenom k seznamům.
Co-authored-by: Glutexo <[email protected]> Co-authored-by: adelpopelkova <[email protected]>
Co-authored-by: adelpopelkova <[email protected]>
Optimization is left as an exercise, but also given a bit later.
> „vrátí“ [vyzní] víc jako „vrátí zpátky do seznamu“ než jako „return“ Co-authored-by: Glutexo <[email protected]>
…e & zip) This includes some additions already in this branch.
Here's one more rework of existing lessons.
enumerate
&zip
are split outenumerate
&zip
lesson has some more focus on how iterables behave in generalenumerate
&zip
lesson includes unpacking infor
range
, which should set the scene forenumerate
&zip
Please review the changes as a whole, don't look at individual commits. But, to make cherry-picking easier, don't squash when merging.