Updating prebuilt_nuc_data.h5 with mass.mas16 data #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #18:
prebuilt_nuc_data.h5
to incorporate new atomic mass data frommass.mas16
I'm not sure what the verification process is for a big change to fundamental data, but I updated the few remaining failing tests from the original mass update PR (failing tests here) and ran
travis-run-tests.sh
and it passes the check (CI Test).The nuc data file was updated by editing the existing
prebuilt_nuc_data.h5
file with pyne functions. I edited themake_atomic_mass
function inpyne/dbgen/atomic_mass.py
topass
instead ofreturn
if the atomic_mass node already exists (which it does). Then, it deletes the prebuilt atomic mass node and reads in the data frommass.mas16
. I then similarly editedpyne/dbgen/materials_library.py
topass
instead ofreturn
, delete the prebuilt nodes, and then write in the new material library data.