fix incorrect query param in deployment logs endpoint docs #13620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your site preview for commit 202fe17 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13620-202fe179.s3-website.us-west-2.amazonaws.com. |
komalali
reviewed
Dec 13, 2024
| @@ -1180,7 +1180,7 @@ The `token` is a string that contains the `job`, `offset` and `step` of the next | |||
|
|
|||
| The following query parameters are available: | |||
|
|
|||
| * **nextToken**: A string returned by the previous response, that can be used to get the next set of logs. | |||
| * **continuationToken**: A string returned by the previous response, that can be used to get the next set of logs. | |||
There was a problem hiding this comment.
Can we change this to say that it's the nextToken value returned by the previous response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The deployment logs endpoint actually uses a
continuationTokenquery param instead of the documentednextTokenone. Unfortunately the api response returnsnextToken, so it's a bit confusing :(Unreleased product version (optional)
Related issues (optional)
Fixes https://github.com/pulumi/pulumi-service/issues/24318