Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/11655 saml SCIM limitations #13521

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

GeoffMillerAZ
Copy link
Contributor

Proposed changes

I added the info to each SAML and SCIM guide to address ensuring users are aware of the cardinality limitations of SAML and SCIM providers to Pulumi Organizations. I used a template (shortcode) that when no args are passed to it, it speaks to the concept generically. But when an idp argument is passed to it, it customizes the message for that IdP provider to make it feel more at home in the provider-specific docs. I made one for SCIM and one for SAML. This will also make it very easy to be included in any new guides going forward.

I also update the gitignore to include some dev tools I like to use. I also added a .editorconfig that autmatically fixes the issues with .md files that the git pre-commit hook tests are testing for. This makes it much easier to stay in compliance with the tests. It you're using a supported IDE, it will just put you in compliance on save if you're settings take advantage of that feature.

I also added the tools I updated the .gitignore for to the .prettierconfig so their local files don't mess with the pre-commit hook tests.

One of the tools I added support for is devbox, which sits on top of nix shell. This makes it so anyone using devbox just opens the workspace and the shell will be automatically setup with the right versions of the right tools and config to just run make build and what not and be contributing in no time.

Related issues (optional)

#11655

…t hook tests require. This should reduce the headache by supplying automatic compliance to anyone having that feature enabled in their IDE
…se for working on the project that create unwanted artifacts
…cations to pulumi organizations that can be created with each type of sso protocol
…cations to pulumi organizations that can be created with each type of sso protocol
@pulumi-bot
Copy link
Collaborator

Copy link

@caseyyh caseyyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up!!

Comment on lines 24 to 28
If desired, in addition to the SCIM-managed teams, one can also configure and manage Pulumi-local teams in the Pulumi Cloud. See [Teams](/docs/pulumi-cloud/access-management/teams/) for how to configure teams in the Pulumi Cloud.
{{% /notes %}}

{{< sso-scim-limits-info idp="your Identity Provider" >}}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of visuals, it does look slightly strange to have 2 notes back to back with different styling. Would it be easy to make the SAML & SCIM notes consistent with the existing notes?

Screenshot 2024-12-09 at 1 11 48 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed this now:

image

@@ -0,0 +1,4 @@
{{- $idp := .Get "idp" | default "your Identity Provider" -}}
<div class="note info">
<p><strong>Note:</strong> A single SAML application in {{ $idp }} can support multiple Pulumi organizations. This allows you to manage authentication for multiple teams from one centralized configuration.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitate to include this here, since we don't support this for SCIM and SCIM users will first walk through the SAML step. I would probably drop this note and instead issue forewarning that we don't support multi-org SCIM yet:

If you manage multiple Pulumi organizations and plan to enable SCIM provisioning on your SAML app integration, you must configure separate applications for each organization in {{ $idp }}. Pulumi supports only one Pulumi organization per SCIM-enabled application.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I have this just being the same note each time:

image

@GeoffMillerAZ
Copy link
Contributor Author

@caseyyh ,

is it too much to have the note both

image

and

image

and then again for each IdP?

should I remove the one on Docs > Pulumi Cloud > Identity & access management > SAML(SSO) > Using SAML?

@pulumi-bot
Copy link
Collaborator

@caseyyh
Copy link

caseyyh commented Dec 10, 2024

@caseyyh ,

is it too much to have the note both

and then again for each IdP?

should I remove the one on Docs > Pulumi Cloud > Identity & access management > SAML(SSO) > Using SAML?

Oh good question, I think just the one note on the parent page (not on individual IDP pages) should be okay!

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants