Remove ANSI control chars from GitHub step Summary and PR comment #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update branch
more tests formatting
fix formatting
|
Hi @tgummerer, do you by any chance have time to take a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces striping of ANSI symbols for GitHub step Summary and improves the current one for PR comments.
To resolve #1248
This is similar to #1231, but uses a slightly different approach. Instead of converting ANSI symbols to html tags (using the
ansi-to-htmlpackage), which results in\x1b[30mblackbecoming<span style="color:#000">black</span>, we simply remove them using a regular expression, which results in\x1b[30mblackbecoming justblack.The reason is that neither the Summary nor the PR comment is able to actually render the
<span style="color:#000">block with color. However, all these html tags consume limits for PR comment length and Summary size.