tools/internal/parser: enforce suffix ordering in the ICANN section #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ordering rule is slightly different from the private section: suffix blocks do not get reordered, only the suffixes within each block. Additionally, the ICANN section contains many load-bearing inline comments. To avoid semantic changes, the sorting does not move suffixes over such comments. Unlike in the private section, such movement failures aren't treated as errors, because the subsection comments in the ICANN block have a reasonably consistent meaning.
|
Just a note about ICANN section that there are some ccTLD with
authoritatuve subsections (janet in .uk for example)
…On Thu, Nov 28, 2024, 11:17 AM Dave Anderson ***@***.***> wrote:
The ordering rule is slightly different from the private section: suffix
blocks do not get reordered, only the suffixes within each block.
Additionally, the ICANN section contains many load-bearing inline comments.
To avoid semantic changes, the sorting does not move suffixes over such
comments. Unlike in the private section, such movement failures aren't
treated as errors, because the subsection comments in the ICANN block have
a reasonably consistent meaning.
------------------------------
This will fail CI until #2287
<#2287> is merged, along with
the additional sorting fixups in
https://gist.github.com/danderson/cb0fb30acbec38651cf8c0a1f4275125 for
IDNA domains. Depending on whether #2287
<#2287> is merged with or
without the accent fixes, I can add the remaining fixups in this PR, up to
you @simon-friedberger <https://github.com/simon-friedberger> @groundcat
<https://github.com/groundcat>.
------------------------------
You can view, comment on, or merge this pull request online at:
#2295
Commit Summary
- fc6effe
<fc6effe>
tools/internal/parser: enforce suffix ordering in the ICANN section
File Changes
(1 file <https://github.com/publicsuffix/list/pull/2295/files>)
- *M* tools/internal/parser/clean.go
<https://github.com/publicsuffix/list/pull/2295/files#diff-0b7047a26165524ba3ab7a54d3873b6325430d2eea329384fa305911006c2c23>
(40)
Patch Links:
- https://github.com/publicsuffix/list/pull/2295.patch
- https://github.com/publicsuffix/list/pull/2295.diff
—
Reply to this email directly, view it on GitHub
<#2295>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQTJLLH7B3RV24HOBSS332C5T5HAVCNFSM6AAAAABSVXOTW6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YDGMBUGM3TGNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Does anybody know how I can rebase this on current main to rerun the checks? It seems Github is checking this PR as if it would be applied to the old main which is just useless. |
|
Just manually update the branch, if you have the 'Recommend Branch Updates' option enabled in settings it should show up with a prompt to update the branch. Also it won't merge into 'the old main', even with an outdated branch. |
Agreed, but it makes the check a lot less useful if it doesn't actually check the result of merging. |
|
Oops, sorry I didn't see the main branch got renamed. I'll update my clones to match in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering rule is slightly different from the private section: suffix blocks do not get reordered, only the suffixes within each block. Additionally, the ICANN section contains many load-bearing inline comments. To avoid semantic changes, the sorting does not move suffixes over such comments. Unlike in the private section, such movement failures aren't treated as errors, because the subsection comments in the ICANN block have a reasonably consistent meaning.
This will fail CI until #2287 is merged, along with the additional sorting fixups in https://gist.github.com/danderson/cb0fb30acbec38651cf8c0a1f4275125 for IDNA domains. Depending on whether #2287 is merged with or without the accent fixes, I can add the remaining fixups in this PR, up to you @simon-friedberger @groundcat.